Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parameters drop down #1325

Merged
merged 3 commits into from
Jan 31, 2025
Merged

fix: Fix parameters drop down #1325

merged 3 commits into from
Jan 31, 2025

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Jan 30, 2025

Context

The dropdown menu for a pipeline's parameters in the V2 UI doesn't always stay open and therefore has an unintended effect where it is difficult to select an option from the drop down.

Objective

Fix the dropdown spacing to all be done handled with CSS and removes the additional scroll logic that previously existed.

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@VonnyJap VonnyJap merged commit 88f7846 into master Jan 31, 2025
2 checks passed
@VonnyJap VonnyJap deleted the fix-parameters-drop-down branch January 31, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants