Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical text field editor to spec #379

Closed
tmickel opened this issue Jun 8, 2016 · 2 comments · Fixed by #415
Closed

Vertical text field editor to spec #379

tmickel opened this issue Jun 8, 2016 · 2 comments · Fixed by #415
Labels
bug
Milestone
Backlog

Comments

@tmickel
Copy link
Contributor

tmickel commented Jun 8, 2016 •
edited
Loading

Finish implementing:
#146
and
#147

A couple of the issues:

  • Turn off animated growth of editor and font size for vertical blocks. The growth should only happen in horizontal:
  • Editor is in the wrong position for vertical blocks:

screen shot 2016-06-08 at 12 32 08 pm
@tmickel tmickel added the bug label Jun 8, 2016
@thisandagain thisandagain added this to the Backlog milestone Jun 14, 2016
@tmickel tmickel mentioned this issue Jun 15, 2016
Merged
@mrjacobbloom
Copy link
Contributor

I'm sure you're aware, but there's still a max width on the blocklyHtmlInput:

@tmickel
Copy link
Contributor Author

tmickel commented Jun 16, 2016

Ah - I actually didn't notice that, thanks. I'll raise an issue for that.

tmickel pushed a commit to tmickel/scratch-blocks that referenced this issue Jul 12, 2016
@rachel-fenichel
Merge pull request scratchfoundation#379 from rachel-fenichel/cleanup…
e14e421 
…/more_lint

	More lint and eslint configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix up vertical text field editor tmickel/scratch-blocks
3 participants
@tmickel @thisandagain @mrjacobbloom