Do not consider type(None) injectable (#212)

scrapinghub · Jan 29, 2025 · c813a69 · c813a69
1 parent ece2bf9
commit c813a69
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/tests/test_pages.py b/tests/test_pages.py
@@ -69,6 +69,7 @@ def to_item(self) -> dict:  # type: ignore
             }
 
     assert is_injectable(None) is False
+    assert is_injectable(type(None)) is False
     assert is_injectable(MyClass) is False
     assert is_injectable(MyClass()) is False
     assert is_injectable(MyItemPage) is True

diff --git a/web_poet/pages.py b/web_poet/pages.py
@@ -35,10 +35,6 @@ class Injectable(abc.ABC, FieldsMixin):
     pass
 
 
-# NoneType is considered as injectable. Required for Optionals to work.
-Injectable.register(type(None))
-
-
 def is_injectable(cls: Any) -> bool:
     """Return True if ``cls`` is a class which inherits
     from :class:`~.Injectable`."""