-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(regex-version): removed version 2021.8.27 that breaks dateparser with SegFault #974
fix(regex-version): removed version 2021.8.27 that breaks dateparser with SegFault #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @athossampayo, thank you for opening this PR. I think the correct way to do it is separating the versions with commas, as set in PEP-440: 'regex !=2019.02.19,!=2021.8.27',
Could you try with these semantics?
Thanks! :)
…with SegFault Related to scrapinghub#972
9853019
to
ce4dc15
Compare
Hello @noviluni, thanks for the tip! Did not find a pattern to follow on this case. Already updated the code. If there's anything more to fix, just say. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 231 231
Lines 2609 2609
=======================================
Hits 2564 2564
Misses 45 45 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @athossampayo 👍
fix(regex-version): removed version 2021.8.27 that breaks dateparser with SegFault
Related to #972
Tests result:

Fixes: #972.
Fixes: #973