Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalaj-http to 1.1.4 #89

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

sadikovi
Copy link
Contributor

This PR updates scalaj-http to 1.1.4 and fixes very minor issue around feature imports in CoberturaMultiSourceReader.

Tested using existing unit-tests and manually for one of the repositories by adding custom resolver for this updated build and testing coveralls report on travis.

@sadikovi
Copy link
Contributor Author

This fixes issue with NoSuchMethodError when using coveralls with sbt-spark-package since they use scalaj-http 1.1.4, and sbt selects latest version.

@sksamuel sksamuel merged commit 6bff1d3 into scoverage:master Aug 12, 2016
@sksamuel
Copy link
Member

Thanks.

@sadikovi
Copy link
Contributor Author

@sksamuel thank you very much for merging this PR.

@sadikovi sadikovi deleted the update-scalaj-version branch August 12, 2016 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants