Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use jgit rather than calling out to git #19

Merged
merged 1 commit into from
Aug 31, 2014
Merged

Update to use jgit rather than calling out to git #19

merged 1 commit into from
Aug 31, 2014

Conversation

rorygraves
Copy link
Contributor

And a bunch of general housekeeping as I was in the area.

To address #18 and thus fix https://github.com/ensime/ensime-server/issues/473

Somebody who knows sbt plugins better (@fommil??) should review the spec config side, there are some depreciations but I have no idea how to address them.

sksamuel added a commit that referenced this pull request Aug 31, 2014
Update to use jgit rather than calling out to git
@sksamuel sksamuel merged commit e878094 into scoverage:master Aug 31, 2014
@rorygraves
Copy link
Contributor Author

Cool!, can you publish a new version?

@fommil
Copy link
Contributor

fommil commented Aug 31, 2014

😀 and the whole scala world gets one extra badge (then quickly turns it off again when they remember how bad their coverage is)

@rorygraves
Copy link
Contributor Author

lol, that thought had crossed my mind :)
Ensime's coverage definitely counts as red - even after all the work done so far (although I accept 50% is better than the not measured.

@sksamuel
Copy link
Member

0.99.0 is now released.

@sksamuel
Copy link
Member

Thanks for the work on this.

@fommil
Copy link
Contributor

fommil commented Aug 31, 2014

@rorygraves do you want to do the honours on ensime? :-)

@rorygraves
Copy link
Contributor Author

:) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants