Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Compatibility #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RobLoach
Copy link

Allows running in both Python 2 and 3. Requires more testing.

@scottrice
Copy link
Owner

Awesome! This is something thats come up in the past, and I would love to make this happen.

I'll try to take a look sometime soon, but I appreciate you doing this.

@RobLoach
Copy link
Author

RobLoach commented Feb 3, 2016

Have to run through testing and make sure it's still functional.

@vgonisanz
Copy link

+1

@RobLoach
Copy link
Author

Might be good to just move entirely to Python 3.

@vgonisanz
Copy link

I found this pull request while updating Ice repository to python 3 using 2to3, using this repository with @RobLoach changes. For now is not working but if I get it I will tell you something.

@vgonisanz
Copy link

vgonisanz commented Jan 12, 2017

When you change
match = re.match(ur
for
match = re.match(u
The unit test start failing, result is:

Ran 59 tests in 2.794s

FAILED (failures=3, errors=28)

I run them at main path using:
python -m unittest discover tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants