Merge pull request #8 from scorpion/develop

v1.1.0
scorpion · Sep 30, 2020 · 81bfc6d · 81bfc6d
2 parents 8e9f037 + cc61b09
commit 81bfc6d
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 34 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/dist/index.js b/dist/index.js
@@ -80,11 +80,13 @@ var Scorpion = (function () {
 
       if (args.length === 2) {
         // name, factory
-        return this._register(args[0], args[1]);
+        this._register(args[0], args[1]);
+        return this;
       }
       if (args.length === 3) {
         // name, dependencies, factory
-        return this._register(args[0], args[2], args[1]);
+        this._register(args[0], args[2], args[1]);
+        return this;
       }
       throw new Error('Invalid number of arguments');
     }
@@ -97,11 +99,13 @@ var Scorpion = (function () {
 
       if (args.length === 2) {
         // name, factory
-        return this._register(args[0], args[1], undefined, true);
+        this._register(args[0], args[1], undefined, true);
+        return this;
       }
       if (args.length === 3) {
         // name, dependencies, factory
-        return this._register(args[0], args[2], args[1], true);
+        this._register(args[0], args[2], args[1], true);
+        return this;
       }
       throw new Error('Invalid number of arguments');
     }

diff --git a/package.json b/package.json
@@ -47,5 +47,5 @@
     "prepublish": "npm run bundle",
     "test": "mocha --reporter dot --recursive -r setup-referee-sinon/globals test/unit --compilers js:babel/register"
   },
-  "version": "1.0.4"
+  "version": "1.1.0"
 }
diff --git a/src/index.js b/src/index.js
@@ -52,23 +52,27 @@ export default class Scorpion {
   register(...args) {
     if (args.length === 2) {
       // name, factory
-      return this._register(args[0], args[1]);
+      this._register(args[0], args[1]);
+      return this;
     }
     if (args.length === 3) {
       // name, dependencies, factory
-      return this._register(args[0], args[2], args[1]);
+      this._register(args[0], args[2], args[1]);
+      return this;
     }
     throw new Error('Invalid number of arguments');
   }
 
   forceRegister(...args) {
     if (args.length === 2) {
       // name, factory
-      return this._register(args[0], args[1], undefined, true);
+      this._register(args[0], args[1], undefined, true);
+      return this;
     }
     if (args.length === 3) {
       // name, dependencies, factory
-      return this._register(args[0], args[2], args[1], true);
+      this._register(args[0], args[2], args[1], true);
+      return this;
     }
     throw new Error('Invalid number of arguments');
   }

diff --git a/test/unit/index-spec.js b/test/unit/index-spec.js
@@ -23,6 +23,9 @@ describe('Scorpion', function() {
         di.register('foo');
       }).toThrow();
     });
+    it('returns the scorpion instance', function() {
+      expect(di.register('foo', {})).toBe(di);
+    });
   });
 
   describe('forceRegister', function() {
@@ -32,6 +35,9 @@ describe('Scorpion', function() {
         di.forceRegister('foo', {});
       }).not.toThrow();
     });
+    it('returns the scorpion instance', function() {
+      expect(di.forceRegister('foo', {})).toBe(di);
+    });
   });
 
   describe('getResolvedDependencyCount', function() {
@@ -218,7 +224,7 @@ describe('Scorpion', function() {
       di.register('bar', Scorpion.always('bar'));
       di.register('foo', ['bar'], Scorpion.once(spy));
 
-      return di.get('foo').then(function(bar) {
+      return di.get('foo').then(function() {
         expect(spy).toHaveBeenCalledWith('bar');
       });
     });