Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIRI-1035 password-field optimizations #2052

Merged
merged 5 commits into from
Dec 6, 2024
Merged

SIRI-1035 password-field optimizations #2052

merged 5 commits into from
Dec 6, 2024

Conversation

ymo-sci
Copy link
Contributor

@ymo-sci ymo-sci commented Dec 4, 2024

Description

Makes password visible by clicking the eye-icon and also prevent spellcheckers to get usernames/passwords and give a required hint to not send empty username/password

Bildschirmfoto 2024-12-04 um 10 37 27

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-1035
  • This PR is related to PR:

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

@ymo-sci
optimize password field for login
e7082f5 
spellcheck should be prevented to not send user/passwords to spellcheckers, required gives a plain html-hint that you have to fill out the field

- fixes: SIRI-1035
@ymo-sci
add button to make typed-in password visible by clicking for correction
9a2a95e 
Caveat: the icon must be selected on the click. Selecting it on sirius-ready wont work on the i which is then commented out and replaced by svg..

- fixes: SIRI-1035
@ymo-sci ymo-sci added the 🧬 Enhancement Contains new features label Dec 4, 2024
@ymo-sci
add comment
66b7d28 
- fixes: SIRI-1035
@sabieber sabieber merged commit fa5890b into develop Dec 6, 2024
3 checks passed
@sabieber sabieber deleted the feature/ymo/SIRI-1035-password branch December 6, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabieber sabieber sabieber approved these changes

@jakobvogel jakobvogel jakobvogel approved these changes

@fhaScireum fhaScireum fhaScireum approved these changes

@idlira idlira idlira approved these changes

@mko-sci mko-sci mko-sci approved these changes

@scireum-mbo scireum-mbo scireum-mbo approved these changes

Assignees
No one assigned
Labels
🧬 Enhancement Contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ymo-sci @sabieber @jakobvogel @fhaScireum @idlira @mko-sci @scireum-mbo