Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces addEnumTermAggregation which builds an automatic filter facet #2045

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

mko-sci
Copy link
Contributor

@mko-sci mko-sci commented Nov 4, 2024

Description

Additional Notes

  • This PR fixes or works on following ticket(s): OX-11093

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices

It was necessary to rename the existing addTermAggregation which was dealing with enums in order to be able to add another version which allowed one to manually specify the title in order to avoid an ambiguous method call exception

Fixes: OX-11093
@mko-sci mko-sci added 🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review labels Nov 4, 2024
@mko-sci
Copy link
Contributor Author

mko-sci commented Nov 4, 2024

not sure about the @deprecated annotation, what do you think?

@mko-sci mko-sci merged commit 241b7a9 into develop Nov 5, 2024
5 checks passed
@mko-sci mko-sci deleted the feature/mko/OX-11093 branch November 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Enhancement Contains new features 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants