Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Accounts - Extends user account cards and open search results by the option to jump to a tenant if the user has the support role #2035

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

scireum-mbo
Copy link
Contributor

@scireum-mbo scireum-mbo commented Sep 25, 2024

Description

After:

SIRI-1020-user-accounts.mov
SIRI-1020-OpenSearch.mov

User accounts:
image

Open Search:
image

Additional Notes

  • This PR fixes or works on following ticket(s): SIRI-1020

Checklist

  • Code change has been tested and works locally
  • Code was formatted via IntelliJ and follows SonarLint & best practices
  • Patch Tasks: Is local execution of Patch Tasks necessary? If so, please also mark the PR with the tag.

We only show this if the user is a support user else it won't be shown.

Fixes: SIRI-1020
Only shows up if the user is a support user.

Fixes: SIRI-1020
@scireum-mbo scireum-mbo added the 🧬 Enhancement Contains new features label Sep 25, 2024
@scireum-mbo scireum-mbo changed the title User Accounts - Implements the option to jump to a tenant from a user account card or open search result if the user has the support role User Accounts - Extends user account cards and open search results by the option to jump to a tenant if the user has the support role Sep 25, 2024
@sabieber
Copy link
Member

sabieber commented Sep 25, 2024

Another idea (I know it was not mentioned in the ticket):
Instead of using a separate card action we could also show the tenant name with t:smartValue (like in the process view), which shows the tenant name and opens a tooltip on click which allows to edit or switch to the tenant.

grafik

Something like: <t:smartValue type="tenant" payload="@process.getTenantId()" label="@process.getTenantName()" />

This would also be something that could be used in the content results in OX, if it works

In our case this permission would be: permission-select-tenant

Fixes: SIRI-1020
@sabieber
Copy link
Member

Could you add some screenshots how the new solution looks like?

@sabieber
Copy link
Member

sabieber commented Sep 30, 2024

On your screenshot of the new Open Search result: Isn't the Text above in Parenthesis the Tenant Name? If so I would prefer that this is turned into the smartValue instead of an additional action (same for the content cards in OX)

Or would that not be possible?

This is done because in some cases there might be multiple sets of smartValues on one page, which would lead to unwanted behaviour. For example the popup opening on the first element containing the id "smarty-1" etc.

Fixes: SIRI-1020
@scireum-mbo scireum-mbo merged commit 8397863 into develop Sep 30, 2024
3 checks passed
@scireum-mbo scireum-mbo deleted the feature/mbo/SIRI-1020 branch September 30, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Enhancement Contains new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants