Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids cursor exception processing analytic computers #1945

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

idlira
Copy link
Contributor

@idlira idlira commented Feb 27, 2024

By using streamBlockwise instead of interateAll.

Although batches are emitted to only 250 entities by default (can be overwritten), for each entity, all relevant computers are called, causing the cursor to remain open for quite a long time.

We've seen a MongoCursorNotFoundException at a productive MongoDB instance.

BREAKING: Note that mongo queries shall not provide sorting, which is incompatible with streamBlockwise.

Fixes: OX-10847

By using streamBlockwise instead of interateAll.

Although batches are emitted to only 250 entities by default (can be overwritten), for each entity, all relevant computers are called, causing the cursor to remain open for quite a long time.

We've seen a MongoCursorNotFoundException at a productive MongoDB instance.

Note that mongo queries shall not provide sorting, which is incompatible with streamBlockwise
@idlira idlira added 🐛 Bugfix Contains only a small fix for an existing bug 💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code labels Feb 27, 2024
@idlira idlira added the 👶🏻 Trivial Easy to review label Feb 27, 2024
@idlira idlira merged commit 09c592b into develop Feb 27, 2024
6 checks passed
@idlira idlira deleted the ili/analytics-cursor branch February 27, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 BREAKING CHANGE Contains non-backwards compatible changes to public methods or changes the behavior of existing code 🐛 Bugfix Contains only a small fix for an existing bug 👶🏻 Trivial Easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants