ENH: display the original exception #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this one still relevant? ping @GaelVaroquaux @ogrisel @jnothman ? |
|
We still don't have numpy/scipy as direct deps. Worth having this. LGTM |
ogrisel
pushed a commit
that referenced
this pull request
Sep 14, 2016
rsmith54
pushed a commit
to rsmith54/scikit-learn
that referenced
this pull request
Sep 14, 2016
ogrisel
pushed a commit
that referenced
this pull request
Sep 16, 2016
TomDLT
pushed a commit
to TomDLT/scikit-learn
that referenced
this pull request
Oct 3, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the original traceback when importing numpy or scipy fails in the setup.py
Fixes #5905
Ping @amueller @ogrisel : is this a candidate for backport to a 0.17.1 (will we have an 0.17.1)?