-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add probability module #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to start getting docstrings on both the classes and their methods.
352a03c
to
9d132cd
Compare
3da9260
to
9d132cd
Compare
I removed the docstrings I added and migrated them to PR #558 |
We also need a summary commit message for the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have some explicit tests of the probability API. I know that this will need to change a bit as the other PRs happen, but I think that it is important to make sure that we are explicitly testing each PR.
agreed. tests added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasheinrich Thanks for your patience and for adding tests for probability! LGreatTM!
The only thing left that I will ask is that you
Summarize commit messages into a comprehensive review of the PR
but beyond that I'm happy so I'll approve and leave this to you and @kratsg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just like some clarification about why we do log_prob
for the name. This doesn't seem obvious to me.
Description
another step towards statisfactory. this replaces
log_prob(data,pars)
calls directly to tensorlib with objects that mirror the API oftorch.distributions.Distribution
see e.g. test (which should probably be added here)
https://gist.github.com/lukasheinrich/c69d89333d1c5bd6ea6a0a78eacc919b
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: