Use --no-use-pep517 flag for editable mode with pyproject.toml #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reasons for this are probably best given in
pip
Issue 6434 and PR 6442. In short, though, withpip
v19.1
enforces PEP 517 which does not allow for editable mode installationsAs pyhf has a
pyproject.toml
file for Black this breaks the setup as there is no PEP yet to specify editable installations for developers withpyproject.toml
.pip
PR 6442 fixes this with--no-use-pep517
for the time being. This PR adopts--no-use-pep517
for all installations.This will also need to get addressed later in Issue #399
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: