Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --no-use-pep517 flag for editable mode with pyproject.toml #455

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 25, 2019

Description

The reasons for this are probably best given in pip Issue 6434 and PR 6442. In short, though, with pip v19.1 enforces PEP 517 which does not allow for editable mode installations

Editable installs

This PEP originally specified another hook, install_editable, to do an editable install (as with pip install -e). It was removed due to the complexity of the topic, but may be specified in a later PEP.

As pyhf has a pyproject.toml file for Black this breaks the setup as there is no PEP yet to specify editable installations for developers with pyproject.toml. pip PR 6442 fixes this with --no-use-pep517 for the time being. This PR adopts --no-use-pep517 for all installations.

This will also need to get addressed later in Issue #399

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use --no-use-pep517 flag for editable mode during installation and update docs to reflect this
   - https://github.com/pypa/pip/issues/6434
   - https://github.com/pypa/pip/pull/6442
* Add .eggs to Black exclude list

The reasons for this are probably best given in pip Issue 6434
@matthewfeickert matthewfeickert changed the title Use --no-use-pep517 flag for editable mode Use --no-use-pep517 flag for editable mode with pyproject.toml Apr 25, 2019
@matthewfeickert matthewfeickert self-assigned this Apr 25, 2019
@matthewfeickert matthewfeickert added bug Something isn't working docs Documentation related feat/enhancement New feature or request labels Apr 25, 2019
@matthewfeickert matthewfeickert marked this pull request as ready for review April 25, 2019 21:48
@coveralls
Copy link

coveralls commented Apr 25, 2019

Coverage Status

Coverage remained the same at 97.559% when pulling ea76f0d on fix/pip-v19.1-compliant-no-use-pep517 into 44e0701 on master.

@matthewfeickert matthewfeickert merged commit 0574d87 into master Apr 25, 2019
@matthewfeickert matthewfeickert deleted the fix/pip-v19.1-compliant-no-use-pep517 branch April 25, 2019 23:33
lukasheinrich pushed a commit that referenced this pull request May 7, 2019
* Follow up to PR #455
* Remove -e flag from pip install in postBuild to have Binder avoid issues with PEP 517 and pip
matthewfeickert added a commit that referenced this pull request May 7, 2019
@kratsg kratsg mentioned this pull request Jun 26, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation related feat/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants