docs: Make 'Statement of Need' explicit section in JOSS paper

[matthewfeickert]

Description

As requested by the JOSS Editor in Chief for the review openjournals/joss-reviews#2823, add a section for "Statement of Need". Additionally, move the information on the archival of the pyhf source code on Zenodo and the version used in the review out of "Statement of Need" and (back into) the end of "Summary" as this information doesn't belong with motivational text.

For posterity, related PRs to the JOSS paper revision are:

• PR docs: Add JOSS paper #1089
• PR docs: Explicitly give version number in JOSS paper #1280

Checklist Before Requesting Reviewer

• Tests are passing
• "WIP" removed from the title of the pull request
• Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

• Summarize commit messages into a comprehensive review of the PR

* Add 'Statement of Need' section heading to JOSS paper
   - c.f. https://github.com/openjournals/joss-reviews/issues/2823
* Move information on version and Zenodo archive back to 'Summary' section

[codecov]

Codecov Report

Merging #1290 (8840586) into master (f46c862) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          63       63           
  Lines        3749     3749           
  Branches      535      535           
=======================================
  Hits         3655     3655           
  Misses         55       55           
  Partials       39       39           

Flag	Coverage Δ
unittests	97.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46c862...8840586. Read the comment docs.

[matthewfeickert]

@kratsg @lukasheinrich @cranmer If you can review these changes to the paper:

1. Go to https://whedon.theoj.org/
2. Paper repository address: https://github.com/scikit-hep/pyhf/
3. Custom branch: docs/make-statement-of-need-a-section
4. Compile

and approve of the changes, I'll then tag the Editor and Editor in Chief for the review to get their approval that these changes will be acceptable for publication. We can then merge, update the JOSS review Issue, and request review of the paper again.

For a reference "Statement of Need" section c.f. the JOSS Example paper and bibliography.

[matthewfeickert]

I put this into Draft mode to help protect it from getting merged until after we get Editor okays, but it is ready for review now.

[cranmer]

I would start with the need for a pure python version that is independent of ROOT. Then mention it's faster. And say that yaml aids in likelihood publishing. Not totally sure what "decreases the abstractions between ..." means here.

[cranmer]

well, I wrote this a while ago, but didn't click "submit review". Paper is published! So ignore.

[kratsg]

Yeah, I think we got stuck between vague requirements and having the JOSS take a while in this case. It is a fair balance to just repurpose existing text -- but your point is noted. I doubt we can make that phrasing change.

[matthewfeickert]

Sorry this didn't get posted in time, but thanks for still adding this comment though! Still good to have for the future (as more JOSS papers will come from IRIS-HEP and Scikit-HEP).