-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configurable optimizer tolerance for termination #1184
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
=======================================
Coverage 97.43% 97.44%
=======================================
Files 63 63
Lines 3669 3674 +5
Branches 522 522
=======================================
+ Hits 3575 3580 +5
Misses 55 55
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @kratsg
* Add configurable optimizer tolerance for minimization termination - NB: SciPy defaults to None, iminuit defaults to 0.1 * Add tests to ensure the API for SciPy/iminuit
Pull Request Description
This PR fully resolves #929.
/cc @alexander-held
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: