-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update codebase to Awkward 2.0.0. #156
Conversation
Oh wait—I have to remove debugging code. |
I guess I read the pytest output from Round 1 incorrectly: there was one error causing three test failures. With that error fixed, the other two didn't need to be debugged. So it's done! To explain the changes, most of them are just renaming, but in some of them, I replaced a lot of isinstance(layout, (ak.layouts.ThisArray, ak.layouts.ThatArray)) with layout.is_this or layout.is_that These " I removed code that depends on now-nonexistent types, I also introduced use of the I scanned over the changes once again, and yeah: it was mostly renaming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I wasn't able to test locally. I think I got all the right changes. Let's see what CI thinks.