Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uproot package name migration to uproot3 #157

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Nov 25, 2020

In preparation for the migration uproot4 -> uproot, the "old" uproot migrates to uproot3. Since uproot3 is available now (https://pypi.org/project/uproot3/), this updates uproot -> uproot3. The migration uproot4 -> uproot will follow later.

Also adding upper limits for the pyhf and iminuit versions. Compatibility with pyhf 0.6 will require updates to cabinetry (#150/#156), and the interface changes in iminuit 2.0 will also require an update to cabinetry.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #157 (a28411f) into master (becf994) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          13       13           
  Lines        1471     1471           
  Branches      211      211           
=======================================
  Hits         1441     1441           
  Misses         28       28           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becf994...a28411f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant