fix: nbytes repr for typetracers with nbytes=unknown_length #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfackeldey given that we're allowing reprs to be "non-touching" (in the sense that we don't error if a repr happens after column optimisation, where there are placeholders), I think this can probably say "nbytes: unknown". |
That's a very good point! I'll update the PR accordingly 👍 |
ianna
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@pfackeldey - Thanks for fixing it promptly! Looks good to me. Please, merge it if you finished with it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight from #3348
The
nbytesproperty of a typetracer can be theunknown_lengthsentinel, which doesn't tell us anything about the number of bytes of the array. Thus, we can't add it to the repr.