Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jupyterlite dependency changes #2318

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: jupyterlite dependency changes #2318

merged 1 commit into from
Mar 16, 2023

Conversation

agoose77
Copy link
Collaborator

jupyterlite partitioned into jupyterlite-core and jupyterlite. We pin jupyterlite, but now we need to pin the root package.

@agoose77 agoose77 force-pushed the agoose77/docs-fix-build-jupyterlite branch from f10ee8e to 7e43698 Compare March 16, 2023 15:31
@agoose77 agoose77 temporarily deployed to docs-preview March 16, 2023 15:44 — with GitHub Actions Inactive
@agoose77 agoose77 requested a review from jpivarski March 16, 2023 16:20
jpivarski
jpivarski approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to a specific version? Well, I guess that makes sense because our documentation site is an application, not a library.

@agoose77
Copy link
Collaborator Author

Pinned to a specific version? Well, I guess that makes sense because our documentation site is an application, not a library.

Yes, we need to pin the pyodide version which is closely related. So, for now, it's a hard pin!

@agoose77 agoose77 merged commit bbc6f52 into main Mar 16, 2023
@agoose77 agoose77 deleted the agoose77/docs-fix-build-jupyterlite branch March 16, 2023 22:45
@agoose77 agoose77 mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski