fix: indexing into RegularArray with typetracer
#2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgray would you mind confirming that this fixes your workflow? |
|
Yes this fixes the repro and the more complex actual use case. Thanks! |
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Feb 8, 2023
src/awkward/contents/regulararray.py
Outdated
Comment on lines
420
to
424
| # Handle unknown sizes | ||
| if self._size is None: | ||
| nextsize = None | ||
| start = 0 | ||
| step = 1 if head.step is None else head.step |
There was a problem hiding this comment.
If step is negative, should start be 0?
Slices are completely different when the step is negative; be sure there is a test case for it.
c50fb18 to
81bb5b8
Compare
jpivarski
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR
RegularArrayfor_getitem_at.DR
This latter point (regularisation of indices) is infectious; if a length is not known, or the index is unknown, the result is unknown.
This PR is taking a step towards allowing
intas indices alongside the scalar arrays belong tobackend.index_nplike. We need this if we want concrete slices (array[2:4]) to preserve more information than unknown slices (array[x:y]).