-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for Long64_t #2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it would work! @miranov25, are you able to test from this git branch or do we need to make an Uproot release for testing?
@jpivarski, @ianna, Thank you. I am packing now. Tomorrow morning we will leave for our holiday. I quickly checked your branch, but I have some problems I installed via pip from the GitHub branch. I assume that was ok.
I cannot rule out the possibility that I have done something wrong. Next time I will be able to check in 3-5 days. Error message/stack traceIn [6]: if doTest:
...: rdfTest=rdf1.Range(0,10)
...: rdfTest.Snapshot("testVarRDF","testVarRDF.root", varList)
...: array = ak.from_rdataframe(rdfTest, columns=varList)
...: df=ak.to_dataframe(array)
...: print(df.head(5),df.shape)
...: #
...:
---------------------------------------------------------------------------
OSError Traceback (most recent call last)
Input In [6], in <cell line: 1>()
2 rdfTest=rdf1.Range(0,10)
3 rdfTest.Snapshot("testVarRDF","testVarRDF.root", varList)
----> 4 array = ak.from_rdataframe(rdfTest, columns=varList)
5 df=ak.to_dataframe(array)
6 print(df.head(5),df.shape)
File /venv/venv3/lib/python3.8/site-packages/awkward/operations/ak_from_rdataframe.py:28, in from_rdataframe(rdf, columns)
7 """
8 Args:
9 rdf (`ROOT.RDataFrame`): ROOT RDataFrame to convert into an
(...)
23 See also #ak.to_rdataframe.
24 """
25 with ak._errors.OperationErrorContext(
26 "ak.from_rdataframe", dict(rdf=rdf, columns=columns)
27 ):
---> 28 return _impl(rdf, columns)
File /venv/venv3/lib/python3.8/site-packages/awkward/operations/ak_from_rdataframe.py:32, in _impl(data_frame, columns)
31 def _impl(data_frame, columns):
---> 32 import awkward._connect.rdataframe.from_rdataframe # noqa: F401
34 if isinstance(columns, str):
35 columns = (columns,)
File /alicesw3b/sw/ubuntu2004_x86-64/ROOT/v6-26-04-patches-alice1-local1/lib/ROOT/_facade.py:153, in ROOTFacade._set_import_hook.<locals>._importhook(name, *args, **kwds)
151 except Exception:
152 pass
--> 153 return _orig_ihook(name, *args, **kwds)
File /venv/venv3/lib/python3.8/site-packages/awkward/_connect/rdataframe/from_rdataframe.py:44, in <module>
33 numpy = ak._nplikes.Numpy.instance()
36 cppyy.add_include_path(
37 os.path.abspath(
38 os.path.join(
(...)
42 )
43 )
---> 44 cppyy.add_include_path(
45 os.path.abspath(
46 os.path.join(
47 os.path.dirname(os.path.realpath(__file__)),
48 os.path.pardir,
49 "header-only",
50 )
51 )
52 )
53 compiler = ROOT.gInterpreter.Declare
56 done = compiler(
57 """
58 #include "rdataframe/jagged_builders.h"
59 """
60 )
File /alicesw3b/sw/ubuntu2004_x86-64/ROOT/v6-26-04-patches-alice1-local1/lib/cppyy/__init__.py:221, in add_include_path(path)
219 """Add a path to the include paths available to Cling."""
220 if not os.path.isdir(path):
--> 221 raise OSError("no such directory: %s" % path)
222 gbl.gInterpreter.AddIncludePath(path)
OSError: no such directory: /venv/venv3/lib/python3.8/site-packages/awkward/_connect/header-only
|
@miranov25 installing directly from Git via this_path=$PWD
pushd $(mktemp -d)
git clone --depth=1 --recurse-submodules --shallow-submodules https://github.com/scikit-hep/awkward.git
cd awkward
pipx run nox -s prepare
mkdir -p "$this_path/wheels"
pipx run --python $(which python3) build -w -o "$this_path/wheels" awkward-cpp
pipx run --python $(which python3) build -w -o "$this_path/wheels" .
popd |
No description provided.