-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign cmake entrypoint #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to match the entry points and names?
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 81.98% 81.96% -0.02%
==========================================
Files 68 68
Lines 3919 3921 +2
==========================================
+ Hits 3213 3214 +1
- Misses 706 707 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Could you try it with my changes and see if that fixes sagemath? |
(pyzmq doesn't use the setuptools plugin, so it should be fine. I think we only have ~1 user so far of the setuptools plugin.) |
I just checked and sagemath still builds with your newest changes. I must say, I was not sure it would. |
This makes sure nothing is injected unless a The injection should have been pretty safe, but this is safer. |
Thanks! |
This is a sort of follow up to #413 and #414. In sage-on-gentoo we discovered that the presence of scikit-build-core breaks the building sagemath (cschwan/sage-on-gentoo#783). scikit-build-core also happens to be an indirect dependency for building sagemath's documentation.
On the basis that the presence of setuptolls_rust does not break sagemath's build, I studied the difference with scikit-build-core. I noticed that the elements `bundled in the single "finalize_distribution_options" entrypoint in scikit is split between two different setuptools entrypoints.
This PR reproduce that setup and does a bit of clean up. The bundling of the old _prepare_extension_detection and _prepare_build_cmake_command into finalize_distribution_options being redundant after attributing them directly to separate entrypoints. I also renamed the functions to better characterise them.
Using this PR, sagemath builds without problems and pyzmq, which uses scikit-build-core also builds properly.