Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version file is not generated with setuptools-scm 8 #507

Closed
njzjz opened this issue Sep 20, 2023 · 4 comments
Closed

version file is not generated with setuptools-scm 8 #507

njzjz opened this issue Sep 20, 2023 · 4 comments

Comments

@njzjz
Copy link
Contributor

njzjz commented Sep 20, 2023

Today setuptools-scm released v8.0.0 and v8.0.1. After that, the version file is not generated anymore.

[tool.setuptools_scm]
write_to = "deepmd/_version.py"

However, there is no issue when using setuptools.
@njzjz
Copy link
Contributor Author

njzjz commented Sep 20, 2023

I see #497, but I think it is a different issue.

@henryiii
Copy link
Collaborator

Could you try using the built-in generation option? I'll start by making sure we test that the generated file is generated, but that might be a workaround for now.

@njzjz njzjz mentioned this issue Sep 20, 2023
Merged
@henryiii
Copy link
Collaborator

You can also add "setuptools_scm<8" into your requirements, which does fix it. Verified using cookiecutter gh:scientific-python/cookie. It looks like the default for force_write_version_files is set differently than in <8.

This was referenced Sep 20, 2023
Closed
Merged
henryiii added a commit that referenced this issue Sep 20, 2023
@henryiii
fix: setuptools_scm 8 change (#509)
9115905 
Fixing #507.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
wanghan-iapcm pushed a commit to deepmodeling/deepmd-kit that referenced this issue Sep 21, 2023
@njzjz
fix missing version file with setuptools-scm v8 (#2850)
955df79 
See scikit-build/scikit-build-core#507.

Now it's written to `{site_packages}/deepmd_cli/_version/__init__.py`.
The previous implementation is too complex.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@henryiii
Copy link
Collaborator

Should be working again with 0.5.1. Possibly the next setuptools_scm version will fix too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryiii @njzjz