You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pyodide-build uses an interesting system of shimming the various binaries used during a typical C++ build. It involves the creation of symlinks which point to the same executable (_pywasmcross). This executable uses sys.argv to determine which binary was being called, which consequently breaks under scikit-build-core.
Is there a need for scikit-build-core to resolve symlinks, or can we just use the result of shutil.which directly?
It's not immediately obvious to me why this is suddenly a problem after upgrading to pyodide==0.22.0; the code that generates these links has not changed recently, neither has the program resolution in scikit-build-core.
The text was updated successfully, but these errors were encountered:
agoose77
changed the title
Do not resolve CMake programs
Do not resolve CMake program links
Jan 4, 2023
agoose77
changed the title
Do not resolve CMake program links
Do not resolve program links
Jan 4, 2023
pyodide-build
uses an interesting system of shimming the various binaries used during a typical C++ build. It involves the creation of symlinks which point to the same executable (_pywasmcross
). This executable usessys.argv
to determine which binary was being called, which consequently breaks under scikit-build-core.Is there a need for scikit-build-core to resolve symlinks, or can we just use the result of
shutil.which
directly?It's not immediately obvious to me why this is suddenly a problem after upgrading to
pyodide==0.22.0
; the code that generates these links has not changed recently, neither has the program resolution inscikit-build-core
.The text was updated successfully, but these errors were encountered: