Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not resolve program links #170

Closed
agoose77 opened this issue Jan 4, 2023 · 2 comments
Closed

Do not resolve program links #170

agoose77 opened this issue Jan 4, 2023 · 2 comments

Comments

@agoose77
Copy link
Contributor

agoose77 commented Jan 4, 2023

pyodide-build uses an interesting system of shimming the various binaries used during a typical C++ build. It involves the creation of symlinks which point to the same executable (_pywasmcross). This executable uses sys.argv to determine which binary was being called, which consequently breaks under scikit-build-core.

Is there a need for scikit-build-core to resolve symlinks, or can we just use the result of shutil.which directly?

It's not immediately obvious to me why this is suddenly a problem after upgrading to pyodide==0.22.0; the code that generates these links has not changed recently, neither has the program resolution in scikit-build-core.

@agoose77 agoose77 changed the title Do not resolve CMake programs Do not resolve CMake program links Jan 4, 2023
@agoose77 agoose77 changed the title Do not resolve CMake program links Do not resolve program links Jan 4, 2023
@agoose77
Copy link
Contributor Author

agoose77 commented Jan 4, 2023

Required for scikit-hep/awkward#2062

henryiii added a commit that referenced this issue Jan 27, 2023
Addresses #170.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator

henryiii commented Feb 8, 2023

I think this is fixed in main, could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants