Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finsberg/change testing workflow #33

Merged
merged 12 commits into from
Sep 26, 2022
Merged

Conversation

finsberg
Copy link
Member

@finsberg finsberg commented Sep 24, 2022

  • Setup matrix for testing python versions.
  • Add configurations for pytest to pyproject.toml
  • Move setup.cfg to .flake8 since it only contains flake8 configurations.
  • Skip testing of building docs - this is done in the build docs workflow anyway
  • Run coverage report after test suit - no need to run pytest one extra time

@finsberg finsberg marked this pull request as ready for review September 24, 2022 19:44
@finsberg finsberg requested a review from jorgensd September 24, 2022 19:44
@finsberg
Copy link
Member Author

One thing I am thinking is if we need to run this workflow on pull-requests to main when we already run it on every push?

setup.cfg Outdated Show resolved Hide resolved
.github/workflows/test_package.yml Outdated Show resolved Hide resolved
.github/workflows/test_package.yml Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@jorgensd
Copy link
Member

One thing I am thinking is if we need to run this workflow on pull-requests to main when we already run it on every push?

No, we do not. I would suggest doing it on PRs

@finsberg
Copy link
Member Author

One thing I am thinking is if we need to run this workflow on pull-requests to main when we already run it on every push?

No, we do not. I would suggest doing it on PRs

Run test CI only when push or PR to main: b0a76c4

@finsberg finsberg merged commit e1624a2 into main Sep 26, 2022
@jorgensd jorgensd deleted the finsberg/change-testing-workflow branch October 17, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants