Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding list of packages to exclude from cleanup #36

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 15, 2023

This is to add a file to host the agreed upon exceptions for the cleanups. Neither the number version nor the date based cleanup will run for these.

CI is expected to fail as
Fixes #34

cc @mattip

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions to make is easier for future packages to be tested (if needed). Otherwise thanks and looks good.

.github/workflows/remove-wheels.yml Show resolved Hide resolved
.github/workflows/remove-wheels.yml Show resolved Hide resolved
@matthewfeickert
Copy link
Member

matthewfeickert commented Aug 15, 2023

The reason the CI will fail regardless of checkout is described in #32 (comment)

@mattip
Copy link

mattip commented Aug 17, 2023

Perhaps the retention policy should be mentioned in the README.md as well?

@bsipocz
Copy link
Member Author

bsipocz commented Aug 17, 2023

Yeah, good point, I'll add it there, too.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 17, 2023

Given the one approval, and the discussion on the rest, I go ahead and merge this now.

@bsipocz bsipocz merged commit bb8679d into scientific-python:main Aug 17, 2023
@bsipocz bsipocz deleted the CI_cleanup_exception_list branch August 23, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exclude openblas-libs from the cleanup job
4 participants