Namespace #146
Open
Namespace #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwehr
reviewed
Sep 17, 2016
| int day; | ||
| int hour; | ||
| int min; | ||
| AisMdate() { month = day = hour = min = 0; }; |
There was a problem hiding this comment.
Initialization should be done as an initializer list.
| @@ -373,6 +373,16 @@ enum Dac { | |||
|
|
|||
| class AisBitset; | |||
|
|
|||
| class AisMdate | |||
There was a problem hiding this comment.
I'm not sure this class adds alot. For starters, the class name doesn't mean anything to me. Perhaps a better class name and definitely needs a comment.
| @@ -373,6 +373,16 @@ enum Dac { | |||
|
|
|||
| class AisBitset; | |||
|
|
|||
| class AisMdate | |||
| { | |||
| public: | |||
There was a problem hiding this comment.
Needs to be formatted with the clang-format using the google style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace libais for test program