Make Read/Write Buffer Size configurable #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwartzmx
approved these changes
Dec 3, 2019
| @@ -50,8 +52,8 @@ type auth struct { | |||
|
|
|||
| func (ws *Ws) connect() (err error) { | |||
| d := websocket.Dialer{ | |||
| WriteBufferSize: 8192, | |||
| ReadBufferSize: 8192, | |||
| WriteBufferSize: ws.writeBufSize, | |||
There was a problem hiding this comment.
is there a way to have them still default to 8192? Otherwise I think this is good.
There was a problem hiding this comment.
Thanks, added defaults of 8192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across an issue when using Gremtune with Neptune in that if the query sent to Neptune is larger than 8K (the hard coded buffer size value in gremtune), the request is split into multiple websocket frames and Neptune doesn't seem to support that. It tries processing the part of the query in the first frame and fails. This PR is to make the buffer size configurable, so we can specifically increase the write buffer size to fit our query length.