fix: Improve graceful shutdown

schw4rzlicht · Jun 8, 2020 · 626430d · 626430d
1 parent 56fd884
commit 626430d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/__tests__/index.test.ts b/__tests__/index.test.ts
@@ -94,14 +94,14 @@ test("Invalid config", async () => {
     restoreConfigFile(configTmp);
 });
 
-test("Exit with error", () => {
+test("Exit with error", async () => {
 
     let consoleSpy = jest.spyOn(console, "error").mockImplementationOnce(() => {});
 
     // @ts-ignore
     let exitSpy = jest.spyOn(process, "exit").mockImplementationOnce(() => {});
 
-    index.exitWithError(new Error("Fuck dat!"));
+    await expect(index.exitWithError(new Error("Fuck dat!"))).resolves.toBeUndefined();
 
     expect(consoleSpy).toHaveBeenCalledWith(expect.stringMatching("Fuck dat! Exiting..."));
     expect(exitSpy).toHaveBeenCalledWith(1);

diff --git a/src/lib/index.ts b/src/lib/index.ts
@@ -16,15 +16,7 @@ export async function main() {
 
     process.on("SIGINT", () => {
         console.log(chalk`\n{bold Thank you for using twitch2ma} ❤️`);
-        if(twitch2Ma) {
-            twitch2Ma.stop()
-                .then(() => process.exit(0))
-                .catch((err: Error) => {
-                    error(err.message);
-                    process.exit(1);
-                })
-        }
-        process.exit(0);
+        exit(0);
     });
 
     return require("libnpm")
@@ -114,9 +106,22 @@ export async function loadConfig(configFile: string): Promise<Config> {
     return new Config(rawConfigObject);
 }
 
-export function exitWithError(err: Error) {
+async function exit(statusCode: number) {
+    let stopPromise = Promise.resolve();
+    if(twitch2Ma) {
+        stopPromise
+            .then(() => twitch2Ma.stop())
+            .catch((err: Error) => {
+                error(err.message);
+                process.exit(1);
+            })
+    }
+    return stopPromise.then(() => process.exit(statusCode));
+}
+
+export async function exitWithError(err: Error) {
     error((err.message.slice(-1) === "!" ? err.message : err.message + "!") + " Exiting...");
-    process.exit(1);
+    return exit(1);
 }
 
 function channelMessage(channel: string, message: string): void {