Add compatibility with symfony/finder 3.4 and Symfony 7 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Wouter, good so see you! How are you doing? :) I cannot remember why the finder component is limited to Symfony 4, while all the others aren't. Seems to be fine with 3,4 though 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm planning to use this project to help us remove a legacy Symfony 3.4 application. The Finder component used by the analyzer was the only Symfony component not marked as 3.4 compatible. However, it uses no 4.0+ specific features as far as I can see.
While working on it, I also took the opportunity to mark Symfony 7.0+ support for this library.