-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for asciidoctor command in place of asciidoc #56
base: master
Are you sure you want to change the base?
Conversation
Asciidoctor is used by default. Add the following config option to use AsciiDoc:
|
@mojavelinux I ran a build on this PR branch with
I also ran the tests on
|
Next, I'm running this on a legacy book to see how it works. |
It looks like some updates are required. I ran this a while back, but I can't remember if it was all working as of the last update to master. I'll run it from my end later tonight. Side note: legacy fenced code block syntax for source listings is not supported in Asciidoctor. You can either use GitHub-flavored fenced code or AsciiDoc listing, literal or open blocks w/ the |
@mojavelinux Looks good for HTML output from a quick run on our vintage Gradle Book. Happy to merge this PR as-is if you like. Let me know. |
+1 as regular asciidoc is missing a lot of features like cover images |
fad9ba8
to
e811f1c
Compare
I updated the PR so it can be merged and I also fixed the tests. Note that git-scribe does not currently use Asciidoctor EPUB3, so support for the cover images will be the same even after this fix. However, the DocBook toolchain does support a cover image to my knowledge...you just need to sort out where to put it and how to enable it. I didn't test it. |
No description provided.