-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): add docker helper #906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Apr 23, 2020
cmd/scw/testdata/test-all-usage-registry-docker-helper-get-usage.stderr.golden
Outdated
Show resolved
Hide resolved
remyleone
reviewed
Apr 23, 2020
remyleone
reviewed
May 6, 2020
remyleone
reviewed
May 6, 2020
1cf77a1
to
d8814d2
Compare
remyleone
previously approved these changes
May 6, 2020
jerome-quere
suggested changes
May 6, 2020
cmd/scw/testdata/test-all-usage-registry-configure-docker-usage.stderr.golden
Outdated
Show resolved
Hide resolved
cmd/scw/testdata/test-all-usage-registry-docker-helper-erase-usage.stderr.golden
Outdated
Show resolved
Hide resolved
3a7a025
to
4c84d19
Compare
513d314
to
6a4cc04
Compare
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
Signed-off-by: Patrik Cyvoct <pcyvoct@scaleway.com>
6a4cc04
to
b7329bb
Compare
10e6b7e
to
f71129d
Compare
jerome-quere
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Theo Bob Massard <tbobm@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrik Cyvoct pcyvoct@scaleway.com