Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): add stocks in server-type list #827

Merged
merged 5 commits into from
Apr 3, 2020
Merged

feat(instance): add stocks in server-type list #827

merged 5 commits into from
Apr 3, 2020

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Apr 2, 2020 •
edited
Loading

This PR also proposes a new EnumMarshalFunc as a replacement of BindAttributesMarshalFunc.

jerome-quere
jerome-quere previously approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jerome-quere
jerome-quere approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit 3fb02e0 into scaleway:v2 Apr 3, 2020
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
chore: cleanup code (scaleway#827)
6863c77
@remyleone remyleone added the instance Instance issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinBrosse @jerome-quere @remyleone