Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for URL signatures #6

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Add support for URL signatures #6

merged 1 commit into from
Jun 28, 2020

Conversation

janklimo
Copy link
Collaborator

No description provided.

pfranck
pfranck reviewed Jun 15, 2020
View reviewed changes
Copy link
Contributor

@pfranck pfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick feedback

lib/cloudimage/uri.rb Outdated Show resolved Hide resolved
@janklimo janklimo force-pushed the url-signature branch 2 times, most recently from 406b67a to 850ae22 Compare June 26, 2020 13:23
@janklimo janklimo merged commit 8730f5e into master Jun 28, 2020
@janklimo janklimo deleted the url-signature branch June 28, 2020 03:37
@janklimo janklimo added the enhancement New feature or request label Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfranck pfranck pfranck left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janklimo @pfranck