Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & simplify instructions to run autofix for a one-time migration #26

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

bjaglin
Copy link
Contributor

@bjaglin bjaglin commented Jul 8, 2020

Fix #22

Instructions successfully tested locally against this repo itself, as it uses org.scalatest:scalatest:3.0.6.

@cla-bot
Copy link

cla-bot bot commented Jul 8, 2020

Hi @bjaglin, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you.

@artimasites
Copy link

@cla-bot[bot] check

@cla-bot cla-bot bot added the cla-signed label Jul 8, 2020
@cla-bot
Copy link

cla-bot bot commented Jul 8, 2020

The cla-bot has been summoned, and re-checked this pull request!

@bjaglin bjaglin marked this pull request as ready for review July 8, 2020 11:33
@bjaglin
Copy link
Contributor Author

bjaglin commented Jul 8, 2020

@YannMoisan does this work better for you?

@cheeseng
Copy link
Contributor

cheeseng commented Jul 9, 2020

@bjaglin @bvenners Looks good to me, and I tried the instructions and it worked, too!

Thanks!

@cheeseng cheeseng requested a review from bvenners July 9, 2020 13:56
@bvenners bvenners merged commit 607b8db into scalatest:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala Version Confusion
5 participants