Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the null cases of compareTo. #7

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Test the null cases of compareTo. #7

merged 3 commits into from
Oct 26, 2018

Conversation

craigpastro
Copy link
Contributor

No description provided.

yito88
yito88 previously approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

feeblefakie
feeblefakie reviewed Oct 26, 2018
View reviewed changes
src/test/java/com/scalar/database/io/TextValueTest.java Outdated
}

@Test
public void compareTo_ThisNullVsGivenNonNull_ShouldReturnNegative() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also ! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

yito88
yito88 approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigpastro
Copy link
Contributor Author

craigpastro commented Oct 26, 2018 •
edited
Loading

By the way, it wasn't me who dismissed a review 😳

isaacs/github#1157

Well, technically it seems it was me, but not on purpose.

feeblefakie
feeblefakie approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@feeblefakie feeblefakie merged commit 9e96a0e into master Oct 26, 2018
@feeblefakie feeblefakie deleted the add-tests-to-textvalue branch October 26, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@yito88 yito88 yito88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigpastro @feeblefakie @yito88