FormatOps: check for left brace in multistat block #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Jul 25, 2022
Comment on lines
+3486
to
+3489
| def notOK: Boolean = | ||
| if (1 == 1) { c; a + b }.foo | ||
| else | ||
| false |
There was a problem hiding this comment.
Suggested change
| def notOK: Boolean = | |
| if (1 == 1) { c; a + b }.foo | |
| else | |
| false | |
| def notOK: Boolean = | |
| if (1 == 1) { c; a + b }.foo | |
| else false |
why only fold thenp ?
There was a problem hiding this comment.
else part uses the existing newline. and the then part uses an old rule about {. i will copy the same tests into scala2, they are formatted exactly the same.
i will try to address that rule separately.
Sometimes it starts a smaller region and shouldn't be skipped.
Depending on how scalameta parses the code, the left brace could be just before the multistat block (previously covered) or at the head of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how scalameta parses the code, the left brace could be just before the multistat block (previously covered) or at the head of it. Fixes #3276.