Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatOps: handle if as if no else when keep #3176

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

kitbellew
Copy link
Collaborator

Fixes #3173.

@iuliand-db
Copy link

Thanks a lot for doing this! for what it's worth, LGTM!

@iuliand-db
Copy link

Is there anything we could help to get this in? I could test it locally, but I'd prefer to stick to an official pre-release version than to fork this repo.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am off on vacation, but the pr looks good after a quick look!

@kitbellew
Copy link
Collaborator Author

I am off on vacation, but the pr looks good after a quick look!

thank you! where are you vacationing?

@kitbellew kitbellew merged commit 11abd73 into scalameta:master Mar 31, 2022
@kitbellew kitbellew deleted the 3173 branch March 31, 2022 22:30
@iuliand-db
Copy link

Thanks! Unfortunately it looks like IDEA can't transparently download scalafmt from OSS snapshots, so I still have to wait for a release to Maven Central :(

Any chance for one soon? 🙏

@tgodzik
Copy link
Contributor

tgodzik commented Apr 2, 2022

I am off on vacation, but the pr looks good after a quick look!

thank you! where are you vacationing?

Madrid and Barcelona, unfortunately it's much colder than expected 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newline before multi-line can't be "kept" as in source
3 participants