[WIP] Migrate to 2.13 #3475
[WIP] Migrate to 2.13 #3475
Conversation
| ) def b = 1 | ||
| //@deprecated( | ||
| // message = "a", | ||
| // since = susan |
There was a problem hiding this comment.
I took a quick look, final val susan = "Susan" should help.
| @@ -4,6 +4,7 @@ import java.io.File | |||
|
|
|||
| import scala.concurrent.ExecutionContext | |||
| import scala.concurrent.Future | |||
| import scala.jdk.CollectionConverters._ | |||
There was a problem hiding this comment.
This was usually added via MetalsEnrichments and the DecorateAsScala/DecorateAsJava traits, I think we can just switch to AsJavaExtensions and AsScalaExtensions instead.
There was a problem hiding this comment.
So I started out with that, but then I realized there was a lot of places that only brought in MetalsEnrichments just to use those instead of just using them directly. Do you still think we should do this?
| * If this doesn't scale because we have too many unrelated extension methods | ||
| * then we can split this up, but for now it's really convenient to have to | ||
| * remember only one import. | ||
| */ | ||
| object MetalsEnrichments | ||
| extends DecorateAsJava |
There was a problem hiding this comment.
This was usually added via MetalsEnrichments and the DecorateAsScala/DecorateAsJava traits, I think we can just switch to AsJavaExtensions and AsScalaExtensions instead.
Actually here, we could just replace those I think.
https://www.scala-lang.org/api/current/scala/collection/convert/AsJavaExtensions.html
|
Again, until Bloop gets merged/publish I wouldn't spend a lot of time reviewing this. It was more of just an experiment to see what it'd take to get it to compile. So there is still quite a bit to do. |
|
There are fresh artifacts on https://repo1.maven.org/maven2/ch/epfl/scala/bloop-launcher_2.13/ ;) |
|
Superseded by #3631 |
When I saw scalacenter/bloop#1646 I knew I needed to try this out. I was curious how much work would be needed to migrate to 2.13. This is at least publishable locally now. There are still a lot of warnings, some tests to figure out etc, but I figured I'd throw this up here to give you an idea of the diff to migrate to 2.13.