This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
feat: support new 2.13 artifacts #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33d1077 to
e749d53
Compare
e749d53 to
c1c5d17
Compare
tanishiking
commented
Mar 10, 2022
src/fetchMetals.ts
Outdated
| @@ -16,9 +16,10 @@ export function fetchMetals({ | |||
| (p) => !p.startsWith("-agentlib") | |||
| ); | |||
|
|
|||
| const binaryVersion = serverVersion > "0.11.2" ? "2.13" : "2.12"; | |||
There was a problem hiding this comment.
This comparison seems a bit terrifying, but I guess alphabetical order is sufficient here.
There was a problem hiding this comment.
Oops, it's not ok for 0.11.2-RC1 or something
There was a problem hiding this comment.
Ok, metals-languageclient has semver as dependency and we can use that 👍
|
@tanishiking I've started release - https://github.com/scalameta/metals-languageclient/actions/runs/1962723033 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as scalameta/nvim-metals#346
(As of scalameta/metals#3631 we now have 2.13 artifacts instead of 2.12).
Confirmed we can download
publishLocaled metals server0.11.13-SNAPSHOTwith thisyarn linkin this repoyarn link "metals-languageclient"inmetals-vscodeF5