Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Scala 3 #12

Closed
jpsacha opened this issue Nov 24, 2021 · 0 comments
Closed

Support Scala 3 #12

jpsacha opened this issue Nov 24, 2021 · 0 comments
Labels
enhancement
Milestone
v.0.4.0

Comments

@jpsacha
Copy link
Member

jpsacha commented Nov 24, 2021

As of Scala 2, the MVCfx classes depend on ScalaFXML. ScalaFXML is using macros that are no longer supported in Scala 3. It is not clear if ScalaFXML will support Scala 3, if it will there will be likely API changers (vigoo/scalafxml#32).

Need to provide an alternate means of using MVCfx in Scala 3. The simplest way is to use JavaFX @fxml annotation and attempt to preserve as much as possible of the current MVCfx API. It should be possible to at fully reuse the ModelFX.
@jpsacha jpsacha added this to the v.0.4.0 milestone Nov 24, 2021
jpsacha added a commit that referenced this issue Nov 24, 2021
@jpsacha
Initial support for Scala 3 #12
2c1645a 
Some changes to MVCfx since ScalaFXML is not available for Scala 3
@jpsacha jpsacha closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v.0.4.0
Development

No branches or pull requests
1 participant
@jpsacha