Fix #266: Extended NoInfer adding extraSymbols field

scalafix-core/shared/src/main/scala/scalafix/internal/config/NoInferConfig.scala

@@ -0,0 +1,22 @@
+package scalafix.internal.config
+
+import metaconfig._
+import org.langmeta._
+
+case class NoInferConfig(
+    extraSymbols: List[Symbol] = Nil
+) {
+  implicit val reader: ConfDecoder[NoInferConfig] =
+    ConfDecoder.instanceF[NoInferConfig] { c =>
+        c.getOrElse("extraSymbols")(extraSymbols).map(xs => NoInferConfig(xs))
+    }
+  implicit val symbolReader: ConfDecoder[Symbol] =
+    ConfDecoder.instanceF[Symbol] { c =>
+      c.as[String].map(Symbol.apply)
+    }
+}
+
+object NoInferConfig {
+  val default = NoInferConfig()
+  implicit val reader: ConfDecoder[NoInferConfig] = default.reader
+}

scalafix-core/shared/src/main/scala/scalafix/internal/rule/NoInfer.scala

@@ -1,25 +1,39 @@
 package scalafix.internal.rule
 
+import metaconfig.{Conf, Configured}
+
 import scala.meta._
+import scalafix.internal.config.NoInferConfig
 import scalafix.lint.LintCategory
 import scalafix.lint.LintMessage
-import scalafix.rule.RuleCtx
-import scalafix.rule.SemanticRule
+import scalafix.rule.{Rule, RuleCtx, SemanticRule}
 import scalafix.util.SemanticdbIndex
 import scalafix.util.SymbolMatcher
 
-case class NoInfer(index: SemanticdbIndex)
+case class NoInfer(index: SemanticdbIndex,
+                   config: NoInferConfig = NoInferConfig.default)
     extends SemanticRule(index, "NoInfer")
     with Product {
-  private val badSymbol = SymbolMatcher.exact(NoInfer.badSymbols: _*)
+  private val badSymbol = SymbolMatcher.exact(NoInfer.badSymbols ++ config.extraSymbols: _*)
+
+  def this(index: SemanticdbIndex) =
+    this(index, NoInferConfig.default)
+
+  override def init(config: Conf): Configured[Rule] =
+    config
+      .getOrElse("noInfer")(NoInferConfig.default)
+      .map(c => NoInfer(index, c))
+
   val error: LintCategory =
     LintCategory.error(
       """The Scala compiler sometimes infers a too generic type such as Any.
         |If this is intended behavior, then the type should be explicitly type
         |annotated in the source.""".stripMargin
     )
-  override def check(ctx: RuleCtx): Seq[LintMessage] =
-    ctx.index.synthetics.flatMap {
+
+  override def check(ctx: RuleCtx): Seq[LintMessage] = {
+
+      ctx.index.synthetics.flatMap {
       case Synthetic(pos, _, names) =>
         names.collect {
           case ResolvedName(_, badSymbol(Symbol.Global(_, signature)), _) =>
@@ -29,6 +43,7 @@ case class NoInfer(index: SemanticdbIndex)
               .at(s"Inferred ${signature.name}", pos)
         }
     }
+  }
 }
 
 case object NoInfer {

scalafix-sbt/src/sbt-test/sbt-scalafix/cross-build/.scalafix.conf

@@ -1,4 +1,8 @@
 rules = [
   ProcedureSyntax
   NoAutoTupling
-]
+]
+
+NoInfer.extraSymbols = [
+  "_root_.scala.Predef.any2stringadd."
+]

scalafix-tests/input/src/main/scala/test/NoInfer.scala

@@ -1,5 +1,8 @@
 /*
 rule = NoInfer
+noInfer.extraSymbols = [
+  "_root_.test.NoInfer.B#"
+]
 */
 package test
 
@@ -14,4 +17,6 @@ case object NoInfer {
   }
   case class A()
   List(NoInfer, A())// assert: NoInfer.product
+  case class B()
+  List(B())// assert: NoInfer.b
 }