Fix linter issues discovered while writing scala-lang blogpost. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rule names are now attached to their reported patches. This is necessary to support multiple linters in testkit, but will also later be necessary for escape hatches. The implementation is a bit hacky, but that should not leak into the public api. - Off-by-one errors in lint asserts - Lint category id was wrong for composite rules - Remove trailing `.` when category.id is empty. - Better detection of linters (but still not perfect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to support multiple linters in testkit,
but will also later be necessary for escape hatches.
The implementation is a bit hacky, but that should not leak
into the public api.
.when category.id is empty.