Update scalameta, semanticdb-scalac-core, ... to 4.7.3

[scala-center-steward]

Updates

• org.scalameta:scalameta
• org.scalameta:semanticdb-scalac-core
• org.scalameta:testkit

from 4.6.0 to 4.7.3.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:semver-spec, commit-count:1

[bjaglin]

It does not matter here as println can only have one list of arguments, but I didn't find a built-inway to match a Term.Apply with an arbitrary number of elements.

@ val Term.Apply(expr, _) = q"println()" 
expr: Term = Term.Name(value = "println")

@ val Term.Apply(expr, _) = q"println" 
scala.MatchError: println (of class scala.meta.Term$Name$TermNameImpl)
  ammonite.$sess.cmd48$.<clinit>(cmd48.sc:1)


@ val q"$expr(...$exprssnel)" = q"println()" 
expr: Term = Term.Name(value = "println")
exprssnel: List[Term.ArgClause] = List(Term.ArgClause(values = List(), mod = None))

@ val q"$expr(...$exprssnel)" = q"println" 
expr: Term = Term.Name(value = "println")
exprssnel: List[Term.ArgClause] = List()

@ val q"$expr(..$_)" = q"println" 
scala.MatchError: println (of class scala.meta.Term$Name$TermNameImpl)
  ammonite.$sess.cmd51$.<clinit>(cmd51.sc:1)

It looks like the -nel suffix has no effect. Also, having a Term.Name match the quasiquote syntax for Apply looks weird 🤔

[kitbellew]

didn't 3-dots work for arbitrary?

[bjaglin]

didn't 3-dots work for arbitrary?

It was too arbitrary. I probably misunderstood the usage of suffixes, but I was expecting q"println(...$exprssnel)" not to match q"println" as the captured list is empty.

[kitbellew]

never saw those suffixes before. probably convention in the examples on that page.

[bjaglin]

Putting scalameta 4.7.x upgrade on hold for the moment as:

• Tree extractors (unapply) are key to the current Scalafix API. Without them, the UX becomes much worse for rule authors (example).
• Code generated by scalameta 4.7.x quasiquotes references internal code, that is not guaranteed to be backward compatible. Rules relying on quasiquotes and built against scalameta 4.7.x would be at risk of not working on a future version of scalafix.

Related discussion ongoing on the scalameta Discord.

[bjaglin]

scalameta/scalameta#2916

[bjaglin]

scalameta/scalameta#3067 should fix both issues in the upcoming scalameta release 🎉

[scala-center-steward]

Superseded by #1735.

[SethTisue]

Came to the repo to see if this was being worked on, nice to see that it is :-)

(I don't like to see the Scalameta version we use in the Scala 2 community build falling too far behind...)

[mrdziuban]

Is there any chance this or #1735 will be ready to go soon-ish? I just ran into scalameta/metals#4584 in my codebase and see that it's fixed in scalameta 4.7.0

Alternatively, is it safe to override the scalameta dependency version just in my codebase?

[tgodzik]

Is there any chance this or #1735 will be ready to go soon-ish? I just ran into scalameta/metals#4584 in my codebase and see that it's fixed in scalameta 4.7.0

Alternatively, is it safe to override the scalameta dependency version just in my codebase?

It's not neccessary for Metals, we use our own internal version of Scalameta, we need to update that in Metals.

[mrdziuban]

Sorry if I was unclear @tgodzik -- I'm not using metals, just scalafix. I just happened to find that bug on the metals repo that perfectly describes the error I ran into

[bjaglin]

I'll look at releasing that this week-end

[bjaglin]

#1743

[bjaglin]

@mrdziuban until a new release is cut, using the latest SNAPSHOT should fix your issue. If it does not, please open a ticket.