Fix for #34 - various fixes to install instructions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yakticus
commented
Feb 11, 2017
- better coherence/same layout & flow for all OS pages
- rev to scala 2.12
- simplify mac & windows instructions
- added some gotchas
robinske
reviewed
Feb 11, 2017
setup/setup.md
Outdated
| * **Scala.** Follow the directions for your operating system. | ||
| * **Doodle.** Follow the directions for your operating system. | ||
| * *[Java](https://java.com/en/)* - required to run Scala programs. Your java installation includes the Java Virtual Machine (or JVM), which provides the runtime environment for Scala. | ||
| * *[Doodle](https://github.com/underscoreio/doodle)* - this is a Scala project that includes all the dependencies you will need to complete course exercises, including both Scala and sbt. This is why you don't need to install Scala or sbt separately in order to complete the exercises. |
There was a problem hiding this comment.
Will these links be confusing to people? Like click on them to install them instead of using the instructions we provide?
There was a problem hiding this comment.
I thought I'd include them for completeness. It does say above to use the page for your OS. If you feel strongly I can remove them.
robinske
reviewed
Feb 11, 2017
setup/linux.md
Outdated
|
|
||
| ``` | ||
| $ scala | ||
| Welcome to Scala 2.11.8 (OpenJDK 64-Bit Server VM, Java 1.8.0_102). |
There was a problem hiding this comment.
did we want everyone to be on scala 2.12?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.