Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed given imports and removed reference to toExpr extension (#7608) #7611

Merged

Conversation

machisuji
Copy link
Contributor

Related to issue #7608 and PR #7609 - two wrong given imports are fixed and one obsolete reference to the toExpr has been updated.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

Fixed 2 outdated given imports and removed 1 obsolete reference to toExpr ext.
@machisuji machisuji force-pushed the fix/macros.md-given-and-expr-fixes branch from c9e38db to 373fe42 Compare November 23, 2019 21:52
@machisuji machisuji changed the title fixed given imports and removed reference to toExpr extension (#7608) Fixed given imports and removed reference to toExpr extension (#7608) Nov 23, 2019
@nicolasstucki
Copy link
Contributor

Thanks @machisuji

@machisuji
Copy link
Contributor Author

P.S. I did sign the Scala CLA.

@nicolasstucki nicolasstucki merged commit 3016573 into scala:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants