Fix errors while running publishSigned #7279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2389d80 to
a419202
Compare
|
Should I also merge this in 0.19.x? |
In 54266c1 I upgraded sbt-pgp from 1.1.0 to 2.0.0-M2, this changed the way signing was done: instead of using the bouncycastle Java library, sbt-pgp now just calls gpg. Unfortunately, it turns out that multiple parallel calls to gpg can lead to the gpg-agent running out of memory, causing `publishSigned` to fai, as happened in https://dotty-ci.epfl.ch/lampepfl/dotty/1487/1/8 while trying to publish Dotty 0.19.0-RC1: gpg: signing failed: Cannot allocate memory I've opened an issue at sbt/sbt-pgp#168, but meanwhile this is fixed by reverting back to using bouncycastle by setting -DSBT_PGP_USE_GPG=false.
a419202 to
bdbe657
Compare
I've relaunched a publish build of 0.19 (https://dotty-ci.epfl.ch/lampepfl/dotty/1488), but if that fails I suggest doing that, yes. |
|
Cool - thanks for looking into it! |
42 tasks
|
Come to think about it I'll merge it on 0.19.x once it passes the CI. 0.18.1 stable did not have problems with signing (though still failed due to a sonatype glitch), yet 19-RC failed 3 times due to the signing problem. |
anatoliykmetyuk
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 54266c1 I upgraded sbt-pgp from
1.1.0 to 2.0.0-M2, this changed the way signing was done: instead of
using the bouncycastle Java library, sbt-pgp now just calls gpg.
Unfortunately, it turns out that multiple parallel calls to gpg can lead
to the gpg-agent running out of memory, causing
publishSignedtofai, as happened in https://dotty-ci.epfl.ch/lampepfl/dotty/1487/1/8
while trying to publish Dotty 0.19.0-RC1:
gpg: signing failed: Cannot allocate memory
I've opened an issue at sbt/sbt-pgp#168, but
meanwhile this is fixed by reverting back to using bouncycastle by
setting SBT_PGP_USE_GPG=0 as documented in the README of sbt-pgp.