Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace quoted toExpr with Expr.apply #7267

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki self-assigned this Sep 19, 2019
@nicolasstucki nicolasstucki force-pushed the move-quoted-lifters-inot-expr branch 2 times, most recently from f318309 to 86ba502 Compare September 19, 2019 14:29
@nicolasstucki nicolasstucki marked this pull request as ready for review September 19, 2019 15:34
@nicolasstucki nicolasstucki added this to the 0.19 Tech Preview milestone Sep 19, 2019
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it reads much better -- the intent of the code is immediately obvious to the reader.

@liufengyun liufengyun force-pushed the move-quoted-lifters-inot-expr branch from 86ba502 to 456c8b3 Compare September 20, 2019 09:16
@anatoliykmetyuk anatoliykmetyuk merged commit f363bd2 into scala:master Sep 20, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the move-quoted-lifters-inot-expr branch September 20, 2019 09:43
@milessabin
Copy link
Contributor

@nicolasstucki this is great ... but would you mind tagging me whenever you push changes to dotty-staging/shapeless (or PR-ing the change against milessabin/shapeless if you're feeling enthusiastic).

@milessabin
Copy link
Contributor

Merged into shapeless-3-staging here: dotty-staging/shapeless#1.

@nicolasstucki
Copy link
Contributor Author

Will tag you next time.

@nicolasstucki
Copy link
Contributor Author

I was planning to do it myself but I see that you did it faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants